fix: increase acceptable time deviation for stop tests with -t #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
stop-timeout
branch
from
4f4e9bd to
6fc2639
Compare
ginglis13
approved these changes
Sep 19, 2023
pendo324
approved these changes
Sep 19, 2023
sam-berning
pushed a commit
that referenced
this pull request
Sep 20, 2023
🤖 I have created a release *beep* *boop* --- ## [0.7.4](v0.7.3...v0.7.4) (2023-09-20) ### Bug Fixes * Fix container filepath to make it platform independent ([#80](#80)) ([5496e94](5496e94)) * increase acceptable time deviation for stop tests with -t ([#81](#81)) ([c292f6d](c292f6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Increase acceptable time deviation from 500ms -> 750ms.
This test checks to see that the
-t/--timeflag waits a certain amount of time (in the test's case, 1s) before sending the stop signal and killing the container. We're currently seeing fairly frequent failures of this test infinch-core, with stop times very slightly outside of the acceptable range:This exact timing isn't super critical, and these test failures are kind of painful for merging PRs, so increasing the allowable deviation makes sense here.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.